STRLCPY/wrongsecrets

Merge pull request #688 from OWASP/feat/add-eslint
```
feat: add eslint to pre-commit
```
Jeroen Willemsen committed with GitHub 1 year ago

c843f33f

2 parents
44e0e90f
54c0e902

Revision indexing in progress... (symbol navigation in revisions will be accurate after indexed)

■ ■ ■ ■ ■ ■

.eslintrc.js

1	+	module.exports = {
2	+	env: {
3	+	browser: true,
4	+	commonjs: true,
5	+	es2021: true
6	+	},
7	+	extends: 'standard',
8	+	overrides: [
9	+	],
10	+	parserOptions: {
11	+	ecmaVersion: 'latest'
12	+	},
13	+	rules: {
14	+	}
15	+	}
16	+

■ ■ ■ ■ ■ ■

.github/workflows/pre-commit.yml

		skipped 22 lines
23	23		uses: actions/setup-python@v4
24	24		with:
25	25		python-version: "3.9"
	26	+	- uses: actions/setup-node@v3
	27	+	with:
	28	+	node-version: 18
	29	+	cache: "npm"
	30	+	- name: Install npm dependencies
	31	+	run: npm install
26	32		- uses: actions/cache@v3
27	33		name: Cache plugin dir
28	34		with:
		skipped 24 lines

■ ■ ■ ■ ■ ■

.pre-commit-config.yaml

		skipped 31 lines
32	32		hooks:
33	33		- id: commitlint
34	34		stages: [commit-msg]
	35	+	- repo: https://github.com/eslint/eslint
	36	+	rev: v8.35.0
	37	+	hooks:
	38	+	- id: eslint
	39	+	args:
	40	+	- "--fix"
35	41

■ ■ ■ ■ ■ ■

commitlint.config.js

1	1		// commitlint.config.js
2	2		module.exports = {
3		-	extends: [
4		-	"@commitlint/config-conventional", // scoped packages are not prefixed
5		-	],
6		-	};
	3	+	extends: [
	4	+	'@commitlint/config-conventional' // scoped packages are not prefixed
	5	+	]
	6	+	}
7	7

■ ■ ■ ■ ■ ■

js/index.js

1		-	function secret() {
2		-	var password = "jLJIQZM=" + 9 + "aG7l" + 6 + "LAQ=" + 2 + "UdiM" + 7;
3		-	return password;
4		-	}
	1	+	/* eslint-disable no-unused-vars */
	2	+	function secret () {
	3	+	const password = 'jLJIQZM=' + 9 + 'aG7l' + 6 + 'LAQ=' + 2 + 'UdiM' + 7
	4	+	return password
	5	+	}
5	6

package-lock.json

Diff is too large to be displayed.

■ ■ ■ ■ ■ ■

package.json

1	1		{
2	2		"devDependencies": {
3		-	"@commitlint/config-conventional": "^17.4.4"
	3	+	"@commitlint/config-conventional": "^17.4.4",
	4	+	"eslint": "^8.35.0",
	5	+	"eslint-config-standard": "^17.0.0",
	6	+	"eslint-plugin-import": "^2.27.5",
	7	+	"eslint-plugin-n": "^15.6.1",
	8	+	"eslint-plugin-promise": "^6.1.1"
4	9		}
5	10		}
6	11

■ ■ ■ ■ ■ ■

src/main/resources/static/theme-toggle.js

1	1		(function () {
2		-	const darkModeMediaQuery = window.matchMedia("(prefers-color-scheme: dark)");
	2	+	const darkModeMediaQuery = window.matchMedia('(prefers-color-scheme: dark)')
3	3
4		-	function updateToggle(darkMode) {
5		-	document.querySelector(".theme-toggle input[type=radio][value='dark']").checked = darkMode;
6		-	document.querySelector(".theme-toggle input[type=radio][value='light']").checked = !darkMode;
	4	+	function updateToggle (darkMode) {
	5	+	document.querySelector(".theme-toggle input[type=radio][value='dark']").checked = darkMode
	6	+	document.querySelector(".theme-toggle input[type=radio][value='light']").checked = !darkMode
7	7
8		-	document.body.classList.toggle("dark-mode", darkMode);
9		-	}
	8	+	document.body.classList.toggle('dark-mode', darkMode)
	9	+	}
10	10
11		-	darkModeMediaQuery.addEventListener("change", (e) => {
12		-	const darkModeOn = e.matches;
13		-	updateToggle(darkModeOn);
14		-	});
	11	+	darkModeMediaQuery.addEventListener('change', (e) => {
	12	+	const darkModeOn = e.matches
	13	+	updateToggle(darkModeOn)
	14	+	})
15	15
16		-	window.addEventListener("load", function () {
17		-	const radios = document.querySelectorAll(".theme-toggle input[type=radio]");
18		-	radios.forEach((radio) => {
19		-	radio.addEventListener("change", function (e) {
20		-	updateToggle(e.target.value === "dark");
21		-	});
22		-	});
	16	+	window.addEventListener('load', function () {
	17	+	const radios = document.querySelectorAll('.theme-toggle input[type=radio]')
	18	+	radios.forEach((radio) => {
	19	+	radio.addEventListener('change', function (e) {
	20	+	updateToggle(e.target.value === 'dark')
	21	+	})
	22	+	})
23	23
24		-	updateToggle(darkModeMediaQuery.matches);
25		-	});
26		-	})();
	24	+	updateToggle(darkModeMediaQuery.matches)
	25	+	})
	26	+	})()
27	27

Merge pull request #688 from OWASP/feat/add-eslint