STRLCPY/git-open

■ ■ ■ ■ ■ ■

git-open

		skipped 185 lines
186	186		fi
187	187
188	188		if [[ "$domain" == 'bitbucket.org' ]]; then
189		-	# Bitbucket, see https://github.com/paulirish/git-open/issues/80 for why ?at is needed.
190		-	providerBranchRef="/src?at=$remote_ref"
	189	+	providerBranchRef="/src/$remote_ref"
191	190		elif [[ "${#pathargs[@]}" -ge 3 && ${pathargs[${#pathargs[@]} - 3]} == 'scm' ]]; then
192	191		# Bitbucket server always has /scm/ as the third to last segment in the url path, e.g. /scm/ppp/test-repo.git
193	192		# Anything before the 'scm' is part of the server's root context
		skipped 85 lines

■ ■ ■ ■ ■ ■

test/git-open.bats

		skipped 359 lines
360	360		git commit -m a
361	361		git checkout mytag
362	362		run ../git-open
363		-	assert_output "https://bitbucket.org/paulirish/crbug-extension/src?at=mytag"
	363	+	assert_output "https://bitbucket.org/paulirish/crbug-extension/src/mytag"
364	364		}
365	365
366	366		@test "bitbucket: non-origin remote" {
		skipped 9 lines
376	376		git checkout -B "devel"
377	377		run ../git-open
378	378		refute_output --partial "//kisom"
379		-	assert_output "https://bitbucket.org/kisom/consbri/src?at=devel"
	379	+	assert_output "https://bitbucket.org/kisom/consbri/src/devel"
380	380		}
381	381
382	382		@test "bitbucket: open source view with a slash/branch" {
		skipped 2 lines
385	385		git remote set-url origin "https://bitbucket.org/guyzmo/git-repo.git"
386	386		git checkout -B "bugfix/conftest_fix"
387	387		run ../git-open
388		-	assert_output --partial "https://bitbucket.org/guyzmo/git-repo/src"
389		-	# BB appears to be fine with both literal or URL-encoded forward slash
390		-	assert_output --partial "?at=bugfix/conftest_fix"
	388	+	assert_output "https://bitbucket.org/guyzmo/git-repo/src/bugfix/conftest_fix"
391	389		}
392	390
393	391		@test "bitbucket: ssh:// clone urls" {
		skipped 311 lines