Projects STRLCPY fzf Commits 52594355
🤬
  • [shell] 'kill' completion will now require trigger sequence (**)

    'kill **<tab>' instead of 'kill <tab>' just like any other completions.
    
    Close #2716
    Close #385
  • Loading...
  • Junegunn Choi committed 2 years ago
    52594355
    1 parent 0d06c28b
Revision indexing in progress... (symbol navigation in revisions will be accurate after indexed)
  • ■ ■ ■ ■ ■ ■
    CHANGELOG.md
    skipped 14 lines
    15 15   ```
    16 16  - Use SGR mouse mode to support larger terminals
    17 17  - Bug fixes and improvements
     18 +- Shell extension
     19 + - `kill` completion now requires trigger sequence (`**`) for consistency
    18 20   
    19 21  0.30.0
    20 22  ------
    skipped 1217 lines
  • ■ ■ ■ ■ ■
    README.md
    skipped 381 lines
    382 382   
    383 383  #### Process IDs
    384 384   
    385  -Fuzzy completion for PIDs is provided for kill command. In this case,
    386  -there is no trigger sequence; just press the tab key after the kill command.
     385 +Fuzzy completion for PIDs is provided for kill command.
    387 386   
    388 387  ```sh
    389 388  # Can select multiple processes with <TAB> or <Shift-TAB> keys
    390  -kill -9 <TAB>
     389 +kill -9 **<TAB>
    391 390  ```
    392 391   
    393 392  #### Host names
    skipped 323 lines
  • ■ ■ ■ ■ ■
    shell/completion.bash
    skipped 259 lines
    260 260  }
    261 261   
    262 262  _fzf_complete_kill() {
    263  - local trigger=${FZF_COMPLETION_TRIGGER-'**'}
    264  - local cur="${COMP_WORDS[COMP_CWORD]}"
    265  - if [[ -z "$cur" ]]; then
    266  - COMP_WORDS[$COMP_CWORD]=$trigger
    267  - elif [[ "$cur" != *"$trigger" ]]; then
    268  - return 1
    269  - fi
    270  - 
    271 263   _fzf_proc_completion "$@"
    272 264  }
    273 265   
    skipped 78 lines
    352 344   __fzf_defc "$cmd" _fzf_dir_completion "-o nospace -o dirnames"
    353 345  done
    354 346   
    355  -# Kill completion (supports empty completion trigger)
    356  -complete -F _fzf_complete_kill -o default -o bashdefault kill
    357  - 
    358 347  unset cmd d_cmds a_cmds
    359 348   
    360 349  _fzf_setup_completion() {
    skipped 16 lines
    377 366   done
    378 367  }
    379 368   
    380  -# Environment variables / Aliases / Hosts
     369 +# Environment variables / Aliases / Hosts / Process
    381 370  _fzf_setup_completion 'var' export unset
    382 371  _fzf_setup_completion 'alias' unalias
    383 372  _fzf_setup_completion 'host' ssh telnet
     373 +_fzf_setup_completion 'proc' kill
    384 374   
    385 375  fi
    386 376   
  • ■ ■ ■ ■ ■ ■
    shell/completion.zsh
    skipped 284 lines
    285 285   
    286 286   lbuf=$LBUFFER
    287 287   tail=${LBUFFER:$(( ${#LBUFFER} - ${#trigger} ))}
    288  - # Kill completion (do not require trigger sequence)
    289  - if [ "$cmd" = kill -a ${LBUFFER[-1]} = ' ' ]; then
    290  - tail=$trigger
    291  - tokens+=$trigger
    292  - lbuf="$lbuf$trigger"
    293  - fi
    294 288   
    295 289   # Trigger sequence given
    296 290   if [ ${#tokens} -gt 1 -a "$tail" = "$trigger" ]; then
    skipped 34 lines
  • ■ ■ ■ ■
    test/test_go.rb
    skipped 2477 lines
    2478 2478   pid = lines[-1]&.split&.last
    2479 2479   tmux.prepare
    2480 2480   tmux.send_keys 'C-L'
    2481  - tmux.send_keys 'kill ', :Tab
     2481 + tmux.send_keys 'kill **', :Tab
    2482 2482   tmux.until { |lines| assert_operator lines.match_count, :>, 0 }
    2483 2483   tmux.send_keys 'sleep12345'
    2484 2484   tmux.until { |lines| assert lines.any_include?('sleep 12345') }
    skipped 226 lines
Please wait...
Page is in error, reload to recover