STRLCPY/fzf

Panic when fzf was built without version information

So that the package maintainers would immediately know that the build is
incorrect. But is there a way to make build simply fail?

Related: https://github.com/junegunn/fzf.vim/issues/1150

Junegunn Choi committed 4 years ago

3304f284

1 parent 0d5f862d

Total 2 files Show one by one

■ ■ ■ ■ ■ ■

BUILD.md

		skipped 16 lines
17	17		# Build fzf binary and copy it to bin directory
18	18		make install
19	19
20		-	# Build 32-bit and 64-bit executables and tarballs in target
	20	+	# Build fzf binaries and archives for all platforms using goreleaser
	21	+	make build
	22	+
	23	+	# Publish GitHub release
21	24		make release
22		-
23		-	# Make release archives for all supported platforms in target
24		-	make release-all
25		-	```
26		-
27		-	### Using `go get`
28		-
29		-	Alternatively, you can build fzf directly with `go get` command without
30		-	manually cloning the repository.
31		-
32		-	```sh
33		-	go get -u github.com/junegunn/fzf
34	25		```
35	26
36	27		Third-party libraries used
		skipped 16 lines

■ ■ ■ ■ ■ ■

main.go

		skipped 8 lines
9	9		var revision string
10	10
11	11		func main() {
	12	+	if len(version) == 0 {
	13	+	panic("Invalid build: version information missing")
	14	+	}
12	15		protector.Protect()
13	16		fzf.Run(fzf.ParseOptions(), version, revision)
14	17		}
		skipped 1 lines