STRLCPY/criu

get_clean_mount: demote an error to a warning

When testing runc checkpointing, I frequently see the following error:

> Error (criu/mount.c:1107): mnt: Can't create a temporary directory: Read-only file system

This happens because container root is read-only mount.

The error here is not actually fatal since it is handled later
in ns_open_mountpoint() (at least since [1] is fixed), but it is shown
as error in runc integration tests.

Since it is not fatal, let's demote it to a warning to avoid confusion.

[1] https://github.com/checkpoint-restore/criu/issues/520

Signed-off-by: Kir Kolyshkin <[email protected]>

Kir Kolyshkin committed with Andrei Vagin 4 years ago

5c5e7695

1 parent c83a0aae

Revision indexing in progress... (symbol navigation in revisions will be accurate after indexed)

Total 1 files

■ ■ ■ ■ ■ ■

criu/mount.c

		skipped 1103 lines
1104	1104		if (mnt_path == NULL && errno == ENOENT)
1105	1105		mnt_path = mkdtemp(mnt_path_root);
1106	1106		if (mnt_path == NULL) {
1107		-	pr_perror("Can't create a temporary directory");
	1107	+	pr_warn("Can't create a temporary directory: %s\n", strerror(errno));
1108	1108		return NULL;
1109	1109		}
1110	1110
		skipped 2800 lines