STRLCPY/criu

mount: fix double-dump file system bug

In the function dump_one_fs(), there's a comment that says "mnt_bind is
a cycled list, so list_for_each can't be used here." That means that the
list head of the list is also a node of the list.

The subsequent list_for_each_entry() marks all the mount info nodes as
dumped, except it skips the list head, which is also a mount info.
This is the bug we fix.

This bug made CRIU dump a file system twice.
See https://github.com/checkpoint-restore/criu-image-streamer/issues/8

Signed-off-by: Nicolas Viennot <[email protected]>

Nicolas Viennot committed with Andrei Vagin 3 years ago

0b2a7223

1 parent bea9580e

Revision indexing in progress... (symbol navigation in revisions will be accurate after indexed)

Total 1 files

■ ■ ■ ■ ■ ■

criu/mount.c

		skipped 1548 lines
1549	1549		if (ret < 0)
1550	1550		return ret;
1551	1551
	1552	+	pm->dumped = true;
1552	1553		list_for_each_entry(t, &pm->mnt_bind, mnt_bind)
1553	1554		t->dumped = true;
1554	1555		return 0;
		skipped 2387 lines