STRLCPY/alacritty

Add -T short form for --title

Debian-based distributions provide a standard interface to launch a
terminal via the x-terminal-emulator name.  In order for a terminal
emualtor to satisfy that interface, it must

* Be VT100 compatiable
* Support the "-e <command> <args>" CLI option
* Support the "-T <title>" CLI option

Adjust the short form of --title accordingly, providing -t as an alias
to avoid breaking any existing usage.

James McCoy committed with GitHub 1 year ago

a152365c

1 parent 6566dd3d

Revision indexing in progress... (symbol navigation in revisions will be accurate after indexed)

Total 6 files Show one by one

■ ■ ■ ■ ■ ■

CHANGELOG.md

		skipped 6 lines
7	7
8	8		## 0.12.0-dev
9	9
	10	+	### Added
	11	+
	12	+	- Uppercase `-T` short form for `--title`
	13	+
10	14		### Fixed
11	15
12	16		- `--help` output for `--class` does not match man pages
		skipped 1078 lines

■ ■ ■ ■ ■ ■

alacritty/src/cli.rs

		skipped 237 lines
238	238		#[derive(Serialize, Deserialize, Args, Default, Debug, Clone, PartialEq, Eq)]
239	239		pub struct WindowIdentity {
240	240		/// Defines the window title [default: Alacritty].
241		-	#[clap(short, long)]
	241	+	#[clap(short = 'T', short_alias('t'), long)]
242	242		pub title: Option<String>,
243	243
244	244		/// Defines window class/app_id on X11/Wayland [default: Alacritty].
		skipped 233 lines

■ ■ ■ ■ ■ ■

extra/alacritty.man

		skipped 61 lines
62	62		\fB\-\-socket\fR <socket>
63	63		Path for IPC socket creation
64	64		.TP
65		-	\fB\-t\fR, \fB\-\-title\fR <title>
	65	+	\fB\-T\fR, \fB\-\-title\fR <title>
66	66		Defines the window title [default: Alacritty]
67	67		.TP
68	68		\fB\-\-working\-directory\fR <working\-directory>
		skipped 26 lines

■ ■ ■ ■ ■ ■

extra/completions/_alacritty

		skipped 22 lines
23	23		'--working-directory=[Start the shell in the specified working directory]:WORKING_DIRECTORY:_files' \
24	24		'*-e+[Command and args to execute (must be last argument)]:COMMAND: ' \
25	25		'*--command=[Command and args to execute (must be last argument)]:COMMAND: ' \
26		-	'-t+[Defines the window title \[default: Alacritty\]]:TITLE: ' \
	26	+	'-T+[Defines the window title \[default: Alacritty\]]:TITLE: ' \
27	27		'--title=[Defines the window title \[default: Alacritty\]]:TITLE: ' \
28	28		'--class=[Defines window class/app_id on X11/Wayland \[default: Alacritty\]]:general> \| <general>,<instance: ' \
29	29		'-h[Print help information]' \
		skipped 35 lines
65	65		'--working-directory=[Start the shell in the specified working directory]:WORKING_DIRECTORY:_files' \
66	66		'*-e+[Command and args to execute (must be last argument)]:COMMAND: ' \
67	67		'*--command=[Command and args to execute (must be last argument)]:COMMAND: ' \
68		-	'-t+[Defines the window title \[default: Alacritty\]]:TITLE: ' \
	68	+	'-T+[Defines the window title \[default: Alacritty\]]:TITLE: ' \
69	69		'--title=[Defines the window title \[default: Alacritty\]]:TITLE: ' \
70	70		'--class=[Defines window class/app_id on X11/Wayland \[default: Alacritty\]]:general> \| <general>,<instance: ' \
71	71		'--hold[Remain open after child process exit]' \
		skipped 74 lines

■ ■ ■ ■ ■ ■

extra/completions/alacritty.bash

		skipped 30 lines
31	31
32	32		case "${cmd}" in
33	33		alacritty)
34		-	opts="-h -V -q -v -o -e -t --help --version --print-events --ref-test --embed --config-file --socket --option --working-directory --hold --command --title --class msg help"
	34	+	opts="-h -V -q -v -o -e -T --help --version --print-events --ref-test --embed --config-file --socket --option --working-directory --hold --command --title --class msg help"
35	35		if [[ ${cur} == -* \|\| ${COMP_CWORD} -eq 1 ]] ; then
36	36		COMPREPLY=( $(compgen -W "${opts}" -- "${cur}") )
37	37		return 0
		skipped 35 lines
73	73		COMPREPLY=($(compgen -f "${cur}"))
74	74		return 0
75	75		;;
76		-	-t)
	76	+	-T)
77	77		COMPREPLY=($(compgen -f "${cur}"))
78	78		return 0
79	79		;;
		skipped 67 lines
147	147		return 0
148	148		;;
149	149		alacritty__msg__create__window)
150		-	opts="-e -t -h --working-directory --hold --command --title --class --help"
	150	+	opts="-e -T -h --working-directory --hold --command --title --class --help"
151	151		if [[ ${cur} == -* \|\| ${COMP_CWORD} -eq 3 ]] ; then
152	152		COMPREPLY=( $(compgen -W "${opts}" -- "${cur}") )
153	153		return 0
		skipped 15 lines
169	169		COMPREPLY=($(compgen -f "${cur}"))
170	170		return 0
171	171		;;
172		-	-t)
	172	+	-T)
173	173		COMPREPLY=($(compgen -f "${cur}"))
174	174		return 0
175	175		;;
		skipped 30 lines

■ ■ ■ ■ ■ ■

extra/completions/alacritty.fish

		skipped 3 lines
4	4		complete -c alacritty -n "__fish_use_subcommand" -s o -l option -d 'Override configuration file options [example: cursor.style=Beam]' -r
5	5		complete -c alacritty -n "__fish_use_subcommand" -l working-directory -d 'Start the shell in the specified working directory' -r -F
6	6		complete -c alacritty -n "__fish_use_subcommand" -s e -l command -d 'Command and args to execute (must be last argument)' -r
7		-	complete -c alacritty -n "__fish_use_subcommand" -s t -l title -d 'Defines the window title [default: Alacritty]' -r
	7	+	complete -c alacritty -n "__fish_use_subcommand" -s T -l title -d 'Defines the window title [default: Alacritty]' -r
8	8		complete -c alacritty -n "__fish_use_subcommand" -l class -d 'Defines window class/app_id on X11/Wayland [default: Alacritty]' -r
9	9		complete -c alacritty -n "__fish_use_subcommand" -s h -l help -d 'Print help information'
10	10		complete -c alacritty -n "__fish_use_subcommand" -s V -l version -d 'Print version information'
		skipped 11 lines
22	22		complete -c alacritty -n "__fish_seen_subcommand_from msg; and not __fish_seen_subcommand_from create-window; and not __fish_seen_subcommand_from config; and not __fish_seen_subcommand_from help" -f -a "help" -d 'Print this message or the help of the given subcommand(s)'
23	23		complete -c alacritty -n "__fish_seen_subcommand_from msg; and __fish_seen_subcommand_from create-window" -l working-directory -d 'Start the shell in the specified working directory' -r -F
24	24		complete -c alacritty -n "__fish_seen_subcommand_from msg; and __fish_seen_subcommand_from create-window" -s e -l command -d 'Command and args to execute (must be last argument)' -r
25		-	complete -c alacritty -n "__fish_seen_subcommand_from msg; and __fish_seen_subcommand_from create-window" -s t -l title -d 'Defines the window title [default: Alacritty]' -r
	25	+	complete -c alacritty -n "__fish_seen_subcommand_from msg; and __fish_seen_subcommand_from create-window" -s T -l title -d 'Defines the window title [default: Alacritty]' -r
26	26		complete -c alacritty -n "__fish_seen_subcommand_from msg; and __fish_seen_subcommand_from create-window" -l class -d 'Defines window class/app_id on X11/Wayland [default: Alacritty]' -r
27	27		complete -c alacritty -n "__fish_seen_subcommand_from msg; and __fish_seen_subcommand_from create-window" -l hold -d 'Remain open after child process exit'
28	28		complete -c alacritty -n "__fish_seen_subcommand_from msg; and __fish_seen_subcommand_from create-window" -s h -l help -d 'Print help information'
		skipped 4 lines